Handle RTD enabling addons #3103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3103 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 121 121
Lines 18166 18166
Branches 3275 3275
=======================================
Hits 18091 18091
Misses 52 52
Partials 23 23 |
jakkdl
approved these changes
Oct 9, 2024
| @@ -374,10 +381,8 @@ def add_mapping( | |||
| # We have to set this ourselves, not only because it's useful for local | |||
| # testing, but also because if we don't then RTD will throw away our | |||
| # html_theme_options. | |||
| import sphinx_rtd_theme | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
let's attach the comment to the line it's talking about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3064
I'm not sure whether this is required because the docs look fine, but then of course the docs have very many hacks that I'm not aware of.