Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Codecov action to v5 #3161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

webknjaz
Copy link
Member

It's more stable and requires a token that is already in the config.

@webknjaz webknjaz mentioned this pull request Dec 20, 2024
@webknjaz webknjaz force-pushed the maintenance/codecov-v5 branch 3 times, most recently from a4c4838 to e2b6bb6 Compare December 20, 2024 04:23
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55201%. Comparing base (3260974) to head (1290249).

❗ There is a different number of reports uploaded between BASE (3260974) and HEAD (1290249). Click for more details.

HEAD has 116 uploads less than BASE
Flag BASE (3260974) HEAD (1290249)
3.11 14 5
Cython 8 4
3.9 25 9
3.13 14 5
Ubuntu 21 7
macOS 18 6
3.12 15 5
3.10 12 4
Alpine 3 1
pypy-3.10 9 3
Windows 39 13
Additional details and impacted files
@@                  Coverage Diff                  @@
##                 main       #3161          +/-   ##
=====================================================
- Coverage   100.00000%   55.55201%   -44.44799%     
=====================================================
  Files             124         246         +122     
  Lines           18427       37608       +19181     
  Branches         1215        2725        +1510     
=====================================================
+ Hits            18427       20892        +2465     
- Misses              0       16393       +16393     
- Partials            0         323         +323     

see 238 files with indirect coverage changes

@jakkdl
Copy link
Member

jakkdl commented Dec 20, 2024

2024-12-20T11:59:06,572190574+01:00
so yeah, uh, not much to review other than this 🙃

#2951 should have some prior research

@webknjaz
Copy link
Member Author

Yeah, that also surprised me. It does need research… One should probably start by comparing the payloads between the PR and main..

@graingert
Copy link
Member

@webknjaz I think you've not enabled edits from maintainers, so I can't update this branch from the base branch for you

@webknjaz
Copy link
Member Author

Yeah, I often disable that.

It's more stable and requires a token that is already in the config.

Alpine needs curl, gpg, git and jq because of a bug in codecov-action [[1]].

[1]: codecov/codecov-action#1320
@webknjaz webknjaz force-pushed the maintenance/codecov-v5 branch from e2b6bb6 to 1290249 Compare December 24, 2024 12:46
@webknjaz
Copy link
Member Author

Anyway, with the huge reported coverage drop and the flakiness I was observing in Ansible, I'd like to investigate what's broken in Codecov first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants