Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why our MacOS 14 runners failed with CPython 3.13.1 #3171

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Dec 25, 2024

There's two possible solutions that I see:

  • set our runs-on to be macos-15
  • ignore the error, it's not showing something bad anyways

Since the first one is somewhat annoying (we would change it back to macos-latest at some point and local tests would fail for people), the second one is ideal. So I implemented that here.

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but wondering why ignoring PT017?

@A5rocks
Copy link
Contributor Author

A5rocks commented Dec 25, 2024

Looks good, but wondering why ignoring PT017?

It wants me to use pytest.raises but I don't want to assert that an exception will happen, only make sure that it's OK if it happens.

@A5rocks A5rocks added this pull request to the merge queue Dec 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 25, 2024
@A5rocks A5rocks added this pull request to the merge queue Dec 25, 2024
Merged via the queue into python-trio:main with commit 8a28c55 Dec 25, 2024
39 checks passed
@A5rocks A5rocks deleted the remove-explained-xfails branch December 25, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants