Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wasm32-wasip1 as the default WASI target triple #123877

Open
brettcannon opened this issue Sep 9, 2024 · 4 comments
Open

Support wasm32-wasip1 as the default WASI target triple #123877

brettcannon opened this issue Sep 9, 2024 · 4 comments
Assignees
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build OS-wasi type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Sep 9, 2024

Bug report

Bug description:

https://bytecodealliance.zulipchat.com/#narrow/stream/219900-wasi/topic/Is.20.60wasm32-wasi.60.20retired.20in.20preference.20for.20.60wasm32-wasip1.60.3F points out that wasm32-wasi is soft deprecated in favour of wasm32-wasip1 so that wasm32-wasi can be claimed for WASI 1.0. As such, we should move over to making -wasip1 the target triple.

This will require #123042 as well as a version of brettcannon@2959f15 .

CPython versions tested on:

3.13

Operating systems tested on:

Other

Linked PRs

@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error OS-wasi 3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build labels Sep 9, 2024
@brettcannon brettcannon self-assigned this Sep 9, 2024
@vstinner
Copy link
Member

Can't we wait for Python 3.14 to make such change? A soft deprecation doesn't sound like something urgent.

@brettcannon
Copy link
Member Author

Can't we wait for Python 3.14 to make such change?

I'm not making the change until 3.13.1 if that's what you're worried about. But I don't want to leave wasm32-wasi hard-coded as the default target in case WASI 1.0 comes in before the end of 2029 and Python 3.13 suddenly doesn't build out of the box for WASI because we left in the old triple.

I also have a PR to make it easy enough to specify the triple as well, so it won't be a costly transition to specify it manually so some workflow works in 3.13.0 and 3.13.1.

brettcannon added a commit to brettcannon/cpython that referenced this issue Nov 7, 2024
brettcannon added a commit that referenced this issue Nov 7, 2024
…more specific (GH-126552)

Eventually wasm32-wasi will represent WASI 1.0, and so it's currently deprecated so it can be used for that eventual purpose. wasm32-wasip1 is also more specific to what version of WASI is currently supported.

---------

Co-authored-by: Erlend E. Aasland <[email protected]>
@brettcannon
Copy link
Member Author

This is in main, but cherry-picker couldn't make it work for 3.13. I've asked for opinions from the Bytecode Alliance if people think it's worth backporting.

@brettcannon
Copy link
Member Author

Once #126561 lands then I will make a PR to update the buildbot config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build OS-wasi type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants