[3.8] gh-107845: Fix symlink handling for tarfile.data_filter (GH-107846) #108279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-107846) (pythonGH-108209) pythongh-107845: Fix symlink handling for tarfile.data_filter (pythonGH-107846) (cherry picked from commit acbd3f9) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>
`@symlink_test` skip tests on wasm, where symlinks behave inconsistently. Python 3.10 doesn't do wasm and doesn't have the decorator.
This was referenced Aug 22, 2023
|
@ambv, please consider this fix for a security fix for 3.8. |
ethanfurman
approved these changes
Aug 22, 2023
|
There's a new commit after the PR has been approved. @ethanfurman: please review the changes made to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit acbd3f9)
Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Victor Stinner [email protected]
Co-authored-by: Lumír 'Frenzy' Balhar [email protected]
This should only be merged if it's accepted for 3.9: #108274