[3.11] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) #109427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nGH-109423) Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits. (cherry picked from commit e091b9f) Co-authored-by: Victor Stinner <[email protected]>
This was referenced Sep 14, 2023
encukou
added
needs backport to 3.9
|
Thanks @miss-islington for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Thanks @miss-islington for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Oct 8, 2024
…pythonGH-109423) (pythonGH-109427) pythongh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (pythonGH-109423) Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits. (cherry picked from commit e091b9f) (cherry picked from commit f7bfac4) Co-authored-by: Miss Islington (bot) <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Oct 8, 2024
…pythonGH-109423) (pythonGH-109427) pythongh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (pythonGH-109423) Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits. (cherry picked from commit e091b9f) (cherry picked from commit f7bfac4) Co-authored-by: Miss Islington (bot) <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
|
GH-125106 is a backport of this pull request to the 3.10 branch. |
|
GH-125107 is a backport of this pull request to the 3.9 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2024
…09423) (#125106) [3.11] gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) (GH-109427) gh-109396: Fix test_socket.test_hmac_sha1() in FIPS mode (GH-109423) Use a longer key: FIPS mode requires at least of at least 112 bits. The previous key was only 32 bits. (cherry picked from commit e091b9f) (cherry picked from commit f7bfac4) Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Petr Viktorin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a longer key: FIPS mode requires at least of at least 112 bits.
The previous key was only 32 bits.
(cherry picked from commit e091b9f)
Co-authored-by: Victor Stinner [email protected]