Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-112536: Add support for thread sanitizer (TSAN) #112648

Merged
merged 8 commits into from
Dec 30, 2023

Conversation

samety
Copy link
Contributor

@samety samety commented Dec 3, 2023

Adds --with-thread-sanitizer as a configure option and defines _Py_THREAD_SANITIZER when thread sanitizer is enabled.


📚 Documentation preview 📚: https://cpython-previews--112648.org.readthedocs.build/

@colesbury
Copy link
Contributor

@samety - this looks good. When you feel the PR is ready, please mark it as "ready for review"

@colesbury
Copy link
Contributor

Oh, and I think this change should have a NEWS entry. (Use the "blurb" tool: https://pypi.org/project/blurb/)

@samety samety marked this pull request as ready for review December 17, 2023 17:24
@corona10 corona10 self-assigned this Dec 17, 2023
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FYI, I updated the PR message.

@colesbury
Copy link
Contributor

We'll want to make some changes after this. For example, I think we'll want to define MI_TSAN to 1 when _Py_THREAD_SANITIZER is defined. But those can be done in later PRs as we find and fix thread sanitizer issues.

@erlend-aasland erlend-aasland removed their request for review December 18, 2023 21:53
@corona10
Copy link
Member

Sorry for the delay, I will take a look at this PR by end of this week.

@corona10 corona10 merged commit 88cb972 into python:main Dec 30, 2023
43 checks passed
@samety samety deleted the gh-112536_with-thread-sanitizer branch December 30, 2023 12:22
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pitrou pushed a commit to pitrou/cpython that referenced this pull request Mar 17, 2024
@bedevere-app
Copy link

bedevere-app bot commented Mar 17, 2024

GH-116924 is a backport of this pull request to the 3.12 branch.

@bedevere-app
Copy link

bedevere-app bot commented Mar 17, 2024

GH-116926 is a backport of this pull request to the 3.11 branch.

pitrou added a commit that referenced this pull request Mar 17, 2024
…#116924)

* [3.12] gh-112536: Add support for thread sanitizer (TSAN) (gh-112648)
(cherry picked from commit 88cb972)

* Remove doc for configure option (leave it hidden in this branch)

---------

Co-authored-by: Samet YASLAN <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 8, 2024

GH-123833 is a backport of this pull request to the 3.10 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants