gh-67693: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority #113563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple slashes and no authority.
serhiy-storchaka
added
needs backport to 3.11
serhiy-storchaka
changed the title
serhiy-storchaka
added
needs backport to 3.8
needs backport to 3.9
|
It fixes also more serious security issue #67693. |
serhiy-storchaka
force-pushed
the
urls2
branch
from
b54b670
to
26951a7
Compare
vadmium
reviewed
May 12, 2024
| ('//path/to/file', | ||
| ('', 'path', '/to/file', '', '', ''), | ||
| ('', 'path', '/to/file', '', '')), | ||
| ('////path/to/file', |
There was a problem hiding this comment.
This case was broken.
| ('scheme://path/to/file', | ||
| ('scheme', 'path', '/to/file', '', '', ''), | ||
| ('scheme', 'path', '/to/file', '', '')), | ||
| ('scheme:////path/to/file', |
There was a problem hiding this comment.
This case was broken.
| ('file:///tmp/junk.txt', | ||
| ('file', '', '/tmp/junk.txt', '', '', ''), | ||
| ('file', '', '/tmp/junk.txt', '', '')), | ||
| ('file:////tmp/junk.txt', |
There was a problem hiding this comment.
This case was broken.
| ('file:////tmp/junk.txt', | ||
| ('file', '', '//tmp/junk.txt', '', '', ''), | ||
| ('file', '', '//tmp/junk.txt', '', '')), | ||
| ('file://///tmp/junk.txt', |
There was a problem hiding this comment.
This case was broken.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13. |
|
GH-119025 is a backport of this pull request to the 3.11 branch. |
|
GH-119026 is a backport of this pull request to the 3.10 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 14, 2024
…h path starting with multiple slashes and no authority (pythonGH-113563) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-119027 is a backport of this pull request to the 3.9 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 14, 2024
… path starting with multiple slashes and no authority (pythonGH-113563) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-119028 is a backport of this pull request to the 3.8 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 14, 2024
…h path starting with multiple slashes and no authority (pythonGH-113563) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
May 14, 2024
… starting with multiple slashes and no authority (GH-113563) (GH-119023) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
May 14, 2024
… starting with multiple slashes and no authority (GH-113563) (GH-119024) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <[email protected]>
matthewhughes934
pushed a commit
to matthewhughes934/pip
that referenced
this pull request
Jun 23, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] that affects some of our tests on Windows. With the understanding that the new behaviour is indeed desired, split up some tests relying on this behaviour depending on the version of Python. This currently affects only 3.12 and 3.13 but there are other backports for that change in review upstream, so we'll likely need to update this in the future. [1] python/cpython#113563
matthewhughes934
pushed a commit
to matthewhughes934/pip
that referenced
this pull request
Jun 23, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] that affects some of our tests on Windows. With the understanding that the new behaviour is indeed desired, split up some tests relying on this behaviour depending on the version of Python. This currently affects only 3.12 and 3.13 but there are other backports for that change in review upstream, so we'll likely need to update this in the future. [1] python/cpython#113563
matthewhughes934
pushed a commit
to matthewhughes934/pip
that referenced
this pull request
Jun 23, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] that affects some of our tests on Windows. With the understanding that the new behaviour is indeed desired, split up some tests relying on this behaviour depending on the version of Python. This currently affects only 3.12 and 3.13 but there are other backports for that change in review upstream, so we'll likely need to update this in the future. [1] python/cpython#113563
matthewhughes934
pushed a commit
to matthewhughes934/pip
that referenced
this pull request
Jun 23, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] that affects some of our tests on Windows. With the understanding that the new behaviour is indeed desired, split up some tests relying on this behaviour depending on the version of Python. This currently affects only 3.12 and 3.13 but there are other backports for that change in review upstream, so we'll likely need to update this in the future. [1] python/cpython#113563
matthewhughes934
pushed a commit
to matthewhughes934/pip
that referenced
this pull request
Jun 24, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] that affects some of our tests on Windows. With the understanding that the new behaviour is indeed desired, split up some tests relying on this behaviour depending on the version of Python. The sample URL used to check this behaviour was taken from a test in the upstream change (with the new behaviour this URL will round-trip parsing) [1] python/cpython#113563
pradyunsg
pushed a commit
to pypa/pip
that referenced
this pull request
Jun 25, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] that affects some of our tests on Windows. With the understanding that the new behaviour is indeed desired, split up some tests relying on this behaviour depending on the version of Python. The sample URL used to check this behaviour was taken from a test in the upstream change (with the new behaviour this URL will round-trip parsing) [1] python/cpython#113563
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…starting with multiple slashes and no authority (pythonGH-113563)
This was referenced Jul 21, 2024
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
ambv
added a commit
that referenced
this pull request
Sep 4, 2024
…starting with multiple slashes and no authority (GH-113563) (#119028) (cherry picked from commit e237b25) Co-authored-by: Łukasz Langa <[email protected]>
ambv
added a commit
that referenced
this pull request
Sep 5, 2024
…starting with multiple slashes and no authority (GH-113563) (#119027) (cherry picked from commit e237b25) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15297.
Co-authored-by: Ashwin Ramaswami [email protected]