gh-108219: Add credits to free-threading project #123802
Conversation
corona10
added
needs backport to 3.13
Doc/whatsnew/3.13.rst
Outdated
| @@ -354,6 +354,10 @@ disabled with the :envvar:`PYTHON_GIL` environment variable or the | |||
| pip 24.1 or newer is required to install packages with C extensions in the | |||
| free-threaded build. | |||
|
|
|||
| This project has been contributed by many people and the community, | |||
| including Brett Simmers, Dino Viehland, Donghee Na, Ken Jin, Matt Page, and Sam Gross. | |||
There was a problem hiding this comment.
Should this include @iritkatriel and a few others from Microsoft too?
There was a problem hiding this comment.
Please let me know if I miss someone at Microsoft team.
cc @Fidget-Spinner
There was a problem hiding this comment.
Not sure about this, I think there are too many contributors to try listing them exhaustively. Maybe go with something like "Sam Gross and many others"?
There was a problem hiding this comment.
Disclaimer: As the person listed in the description, I am biased, so I have no opinions about it.
But listing people as possible can give motivation to work projects not only for this but also other projects. For the faster-cpython project, they listed as many people as possible, so it was a great honor for me, and it motivated me to participate in other projects.
(And It can also be a good reference for persuading a company to let people work part-time on the CPython project.)
"Sam Gross and many others"?
I think this is the minimum option that should be used if there is controversy regarding this.
There was a problem hiding this comment.
And I also think there should be more people on the list. Please let me know or have the person update the description with more details.
(I just picked people with free-threading labels)
There was a problem hiding this comment.
I can't speak for the MS team because I'm also not employed by them :) but IMO/IIUC the MS team is focused on single-threaded JIT performance mostly. So they werent much involved in the 3.13 free threaded effort, apart from discussions and design help we received from them, which I'm thankful for.
Doc/whatsnew/3.13.rst
Outdated
| This project has been contributed by many people and the community, | ||
| including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin, | ||
| Matt Page, and Sam Gross. | ||
| Meta has supported in the form of many engineer-years to this project. |
There was a problem hiding this comment.
Wording suggestions (on mobile so I can't easily check line wrapping)
| This project has been contributed by many people and the community, | |
| including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin, | |
| Matt Page, and Sam Gross. | |
| Meta has supported in the form of many engineer-years to this project. | |
| This work is thanks to many people and organisations, including the large community of contributors | |
| to Python and third party projects to test and enable free-threading support. | |
| This includes, but is not limited to: | |
| Sam Gross, Ken Jin, Donghee Na, Itamar Oren, Matt Page, Brett Simmers, and Dino Viehland. | |
| Many of these contributors are employed by Meta Inc, | |
| which has provided significant manpower to support this project. |
There was a problem hiding this comment.
Thanks, it's more better, and @itamaro is going to add more detail by next week :)
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Itamar Oren <[email protected]>
|
Thanks @corona10 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
pythonGH-123802) (cherry picked from commit aa3f11f) Co-authored-by: Donghee Na <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Itamar Oren <[email protected]>
|
GH-123847 is a backport of this pull request to the 3.13 branch. |
…ew (GH-123802) (#123847) gh-108219: Add credits to the free-threading entry in What's New (GH-123802) (cherry picked from commit aa3f11f) Co-authored-by: Donghee Na <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Itamar Oren <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--123802.org.readthedocs.build/