gh-126462: Remove duplicate sentences, fix malformatted example in dataclasses "Post-init processing" section #126463
+11
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabraham
requested review from
kumaraditya303,
willingc,
jaraco,
brettcannon,
freakboy3742,
erlend-aasland,
barneygale,
a team,
corona10,
FFY00,
encukou,
hauntsaninja,
ethanfurman,
JelleZijlstra,
AlexWaygood,
terryjreedy,
pfmoore,
pradyunsg,
ericvsmith,
rhettinger,
berkerpeksag,
gaogaotiantian,
gpshead,
cjw296,
isidentical,
Eclips4,
pablogsal and
lysnikolaou
as code owners
freakboy3742
removed request for
gaogaotiantian,
erlend-aasland,
terryjreedy,
lysnikolaou,
ezio-melotti,
brandtbucher,
isidentical,
kumaraditya303,
AlexWaygood and
Eclips4
AlexWaygood
requested review from
freakboy3742
and removed request for
cjw296
|
NOTE: changed the base branch to |
|
What on earth happened with the reviewers |
This is what happens when a PR is opened against a branch different from the one its commit is actually on. This one was a commit on the 3.11 branch but submitted as a PR against main, so it ends up being a PR that includes every single commit in the 3.11 branch as part of the PR, and so everyone involved in all of those backport commits gets auto-added as a reviewer. |
ZeroIntensity
removed request for
jaraco,
brettcannon,
encukou,
berkerpeksag,
gpshead,
abalkin,
warsaw,
vsajip,
tiran,
methane,
1st1 and
asvetlov
|
Rebasing on the correct branch and removing review requests does not unsubscribe people. It would be nice if Gh would let us block creation of such PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GitHub Issue #126462, which only affects Python 3.11 documentation.
dataclassescontains duplicate sentences + malformatted code example #126462