Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126461: Fix _Unpickler_ReadFromFile() error handling #126485

Merged
merged 1 commit into from
Nov 6, 2024
Merged

gh-126461: Fix _Unpickler_ReadFromFile() error handling #126485

merged 1 commit into from
Nov 6, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 6, 2024 •
edited by bedevere-app bot
Loading

Handle _Unpickler_SetStringInput() failure.

@vstinner
pythongh-126461: Fix _Unpickler_ReadFromFile() error handling
88d2575 
Handle _Unpickler_SetStringInput() failure.
@vstinner vstinner added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 6, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 6, 2024
Closed
@vstinner vstinner merged commit a1c57bc into python:main Nov 6, 2024
45 checks passed
@vstinner vstinner deleted the fix_pickle branch November 6, 2024 13:24
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2024
@vstinner @miss-islington
pythongh-126461: Fix _Unpickler_ReadFromFile() error handling (python…
01fa8b9 
…GH-126485)

Handle _Unpickler_SetStringInput() failure.
(cherry picked from commit a1c57bc)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2024

GH-126495 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 6, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2024
@vstinner @miss-islington
pythongh-126461: Fix _Unpickler_ReadFromFile() error handling (python…
01571bf 
…GH-126485)

Handle _Unpickler_SetStringInput() failure.
(cherry picked from commit a1c57bc)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2024

GH-126496 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 6, 2024
vstinner added a commit that referenced this pull request Nov 6, 2024
@miss-islington @vstinner
[3.12] gh-126461: Fix _Unpickler_ReadFromFile() error handling (GH-12…
97ab3cf 
…6485) (#126496)

gh-126461: Fix _Unpickler_ReadFromFile() error handling (GH-126485)

Handle _Unpickler_SetStringInput() failure.
(cherry picked from commit a1c57bc)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Nov 6, 2024
@miss-islington @vstinner
[3.13] gh-126461: Fix _Unpickler_ReadFromFile() error handling (GH-12…
83827ad 
…6485) (#126495)

gh-126461: Fix _Unpickler_ReadFromFile() error handling (GH-126485)

Handle _Unpickler_SetStringInput() failure.
(cherry picked from commit a1c57bc)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @ZeroIntensity