Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126464 Fix jit build on aarch64 macos #126494

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

alonme
Copy link
Contributor

@alonme alonme commented Nov 6, 2024

Updating the Command Line Tools for Xcode version in hope it will solve jit build failure on macos

Copy link

cpython-cla-bot bot commented Nov 6, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Nov 6, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that gh-126465 fixed the JIT failures, and we're waiting on an upstream fix. Do we need this?

@ZeroIntensity ZeroIntensity added infra CI, GitHub Actions, buildbots, Dependabot, etc. topic-JIT labels Nov 6, 2024
@brandtbucher
Copy link
Member

This doesn't seem to fix the issue.

@alonme alonme changed the title gh-126464 Update xcode command line tools for jit build on macos gh-126464 Fix jit build on aarch64 macos Nov 7, 2024
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Awesome, so this probably boils down to a version/path problem...

As a sidenote, I also saw actions/runner-images#10917, which may fix this issue as it removes the newest version of xcode. However, it doesn't hurt to explicitly state SDKROOT anyway. What's interesting is that when I was building LLVM from source awhile ago, I also had to specify SDKROOT for newer LLVM to find headers.

Thanks so much!

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One suggestion:

@@ -134,7 +133,7 @@ jobs:
brew install llvm@${{ matrix.llvm }}
SDKROOT="$(xcrun --show-sdk-path)" \
./configure --enable-experimental-jit ${{ matrix.debug && '--with-pydebug' || '--enable-optimizations --with-lto' }}
make all --jobs 4
SDKROOT="$(xcrun --show-sdk-path)" make all --jobs 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're doing this on line 134 too, maybe just remove both and put export SDKROOT="$(xcrun --show-sdk-path)" before the ./configure step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Done

@brandtbucher brandtbucher merged commit 09d6f5d into python:main Nov 7, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news topic-JIT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants