Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126513: Use helpers for _Py_Specialize_ConstainsOp #126517

Merged
merged 2 commits into from
Nov 6, 2024
Merged

gh-126513: Use helpers for _Py_Specialize_ConstainsOp #126517

merged 2 commits into from
Nov 6, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Nov 6, 2024 •
edited by bedevere-app bot
Loading

This PR actually does two things:

If you think that we should only fix the bug here, I'll revert the usage of helpers.

@Eclips4 Eclips4 requested a review from mpage November 6, 2024 21:04
@bedevere-app bedevere-app bot mentioned this pull request Nov 6, 2024
Closed
@mpage mpage mentioned this pull request Nov 6, 2024
Closed
mpage
mpage approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@mpage mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mpage mpage merged commit 6e03ff2 into python:main Nov 6, 2024
45 checks passed
@Eclips4 Eclips4 deleted the issue-126513 branch November 6, 2024 21:53
@mpage mpage mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpage mpage mpage approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eclips4 @mpage