Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: C API: PyThreadState::on_delete was removed in v3.13 #126536

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhansen
Copy link
Contributor

@rhansen rhansen commented Nov 7, 2024

Just delete the note because PyThreadState::on_delete was not officially public according to the documentation for PyThreadState.


📚 Documentation preview 📚: https://cpython-previews--126536.org.readthedocs.build/

Just delete the note because `PyThreadState::on_delete` was not
officially public according to the documentation for `PyThreadState`.
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 7, 2024
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Most PyThreadState fields aren't supposed to be public anyway.

@@ -1375,10 +1375,6 @@ All of the following functions must be called after :c:func:`Py_Initialize`.
Reset all information in a thread state object. The global interpreter lock
must be held.
.. versionchanged:: 3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep this versionchanged and add a new one for Python 3.13 instead, to keep the full history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants