-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple memory allocation benchmark #132
base: main
Are you sure you want to change the base?
Conversation
I'm happy landing this. Let's give some days if @vstinner wants to take a look. |
Co-authored-by: Pablo Galindo Salgado <[email protected]>
Does it belong to pyperformance which is supposed to be a set of "macro benchmarks"? IMO it's to have benchmarks outside pyperformance. @ericsnowcurrently wants to add the ability to plug your own benchmark suite in pyperformance using configuration files, but I didn't follow his PR recently. |
I would say yes: we have things that are quite small in what they do anyway. C'mon, we even have unpacking tests: pyperformance/pyperformance/data-files/benchmarks/bm_unpack_sequence/run_benchmark.py Lines 10 to 20 in 034f58b
|
Maybe these tests don't belong to pyperformance :-(
It's up to you. |
My PR landed a while back and is part of the most recent release. That said, we already have a bunch of micro benchmarks so I'm not opposed to adding more. (We can separate the bunch later.) However, it would be worth marking them as "micro" sooner rather than later so they are easy to skip. That would involve adding/updating |
@tiran THe benchmark fails for pypy because |
No description provided.