Wget option Added along with a new dropdown menu #265

guptaaryan16 · 2023-06-26T11:52:13Z

Description

Additional context

The feature added is for the users to get access to a wget link to be able to make local development changes in the templates and other necessary uses. Currently changes are not properly tested and may have some UI bugs

What is the purpose of this pull request?

Bug fix
New feature
Other

…et_option

netlify · 2023-06-26T11:52:16Z

✅ Deploy Preview for code-generator ready!

Name	Link
🔨 Latest commit	`76cfe0a`
🔍 Latest deploy log	https://app.netlify.com/sites/code-generator/deploys/64b1151b1e654e0008d5caf1
😎 Deploy Preview	https://deploy-preview-265--code-generator.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vfdev-5

Thanks @guptaaryan16
I left few comments in the code and concerning the UI, let's fix the following:

hint for "Code" button is incorrect
"OR" is not correctly aligned between the buttons

functions/colab.js

src/components/NavCode.vue

vfdev-5 · 2023-07-04T13:14:22Z

src/components/NavCode.vue

+          <button type="button" class="copy-link-button" @click="copyURL">
+            <span class="material-icons">content_copy </span>
+          </button>


There is a bug here, if I generate one link first and then change the template and click on copy link it will copy the old link.
I would tend to remove two buttons here and keep one button: generate -> copy

Also, can we replace browser default dialog box with "Copied" with something else more neat or just remove.

pnpm-lock.yaml

functions/code.js

vfdev-5 · 2023-07-07T22:06:42Z

.github/workflows/ci.yml

@@ -81,6 +81,7 @@ jobs:

      - run: pnpm build
      - run: pnpm test:ci
+        continue-on-error: true


Why do you add this ?

In CI, we run ppm test:ci which runs all tests and sometimes maybe an unrelated test may not pass but this can result in complete failure of the whole test. For instance
https://github.com/pytorch-ignite/code-generator/actions/runs/5489587476/jobs/10006909935?pr=265#step:10:36

Please remove it, this is very dangerous. CI shows green but there can be a related failure

vfdev-5 · 2023-07-07T22:18:59Z

pnpm-lock.yaml

@@ -1,4 +1,4 @@
-lockfileVersion: '6.0'
+lockfileVersion: '6.1'


Why do we need to increment this ?

I think it got auto-updated when I updated my ppm or node version, I required we can push it back to 6.0

Let's revert this

vfdev-5 · 2023-07-07T22:21:07Z

src/components/CodeBlock.vue

@@ -124,7 +124,6 @@ div[class*='language-']::before,
  position: absolute;
  top: 0;
  bottom: 0;
-  z-index: 3;


Also, why these z-index removals ?

During the rendering of this code block the terminal margin line appears in front of the Download Zip Success message and without removing z index, this problem could not be fixed

vfdev-5 · 2023-07-10T08:21:25Z

src/components/NavCode.vue

+.dropdown {
+  position: relative;
+  display: inline-block;
+}


Can we merge this one with above one:

.dropdown { text-align: center; }

vfdev-5 · 2023-07-10T08:23:37Z

src/components/NavCode.vue

+          <i class="material-symbols-outlined icon">terminal</i>
+          <span id="code">Code</span>


We can also try to add this (taken from GH):

  <span id="code">Code</span> <span> <svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true"> <path d="m4.427 7.427 3.396 3.396a.25.25 0 0 0 .354 0l3.396-3.396A.25.25 0 0 0 11.396 7H4.604a.25.25 0 0 0-.177.427Z"></path> </svg> </span>

vfdev-5 · 2023-07-10T08:26:00Z

If we could make this drop down menu like in GH, it would be very nice:

I mean the lines separating the options and text edit + copy button

guptaaryan16 · 2023-07-10T08:36:47Z

Ok @vfdev-5 let me make some more UI changes and have the PR updated

vfdev-5 · 2023-07-10T21:11:34Z

@guptaaryan16 now it looks better but not yet perfect:

<> Code is not aligned, but when I tried it was rather complicated to align ...
and text edit widget still on the left instead of center...
Maybe we can remove the icon and "Clone" ?

…into wget_option

vfdev-5

https://deploy-preview-265--code-generator.netlify.app/create
Looks great 🎉
Thanks @guptaaryan16 !

guptaaryan16 and others added 5 commits June 26, 2023 15:57

Some changes for the new wget code panel

22717ed

Made some more changes and refactoring

e6ed93a

Added text copy button

671cc09

Merge branch 'main' of github.com:guptaaryan16/code-generator into wg…

e53aac9

…et_option

Merge branch 'pytorch-ignite:main' into wget_option

a19bb7f

guptaaryan16 and others added 2 commits June 26, 2023 19:18

Update PaneLeft.vue

b414c57

Made some changes

dbf657c

guptaaryan16 marked this pull request as draft June 26, 2023 14:11

guptaaryan16 and others added 13 commits June 30, 2023 19:22

changed the configuration of code option and download button

886c501

Made few changes in CSS styles of NavCode.vue

5da0df4

Fix bug for NavDownload success message

e88bcd6

Made final changes for the Code dropdown button

bcb492b

A minor change

9394123

Minor fixes

e92d7da

Minor change

efe1642

Minor fix

d1f3293

Last fix

95b9888

minor change in the NavCode

0f37ac9

Merge branch 'pytorch-ignite:main' into wget_option

3e03699

Last fix

6682e82

UI fixes

273e7a6

guptaaryan16 marked this pull request as ready for review July 4, 2023 12:49

vfdev-5 changed the title ~~Wget option Added along with a new dropdown menu [WIP]~~ Wget option Added along with a new dropdown menu Jul 4, 2023

vfdev-5 reviewed Jul 4, 2023

View reviewed changes

guptaaryan16 added 3 commits July 5, 2023 15:59

Made all the required UI fixes for now

75e4094

reconfigured tests

fc47f36

Made some changes

4dc775b

vfdev-5 reviewed Jul 7, 2023

View reviewed changes

guptaaryan16 added 2 commits July 10, 2023 12:16

Added changes to CSS of NavCode and NavDownload for center alignmnet

f73ed43

Added copy notification in NavCode

aa9d21e

vfdev-5 reviewed Jul 10, 2023

View reviewed changes

Fixed issues and reformatted the NavCode tab

cff1ff9

guptaaryan16 added 4 commits July 11, 2023 16:16

Fixed button styles, formatting and tests

96fbb30

Merge branch 'main' of https://github.com/guptaaryan16/code-generator …

8cbaecd

…into wget_option

Fix tests for failing on await

24d79d6

Fixed and reduced CSS for NavCode.vue

76cfe0a

vfdev-5 approved these changes Jul 14, 2023

View reviewed changes

guptaaryan16 merged commit 8286377 into pytorch-ignite:main Jul 14, 2023
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wget option Added along with a new dropdown menu #265

Wget option Added along with a new dropdown menu #265

guptaaryan16 commented Jun 26, 2023 •

edited

Loading

netlify bot commented Jun 26, 2023 •

edited

Loading

vfdev-5 left a comment

vfdev-5 Jul 4, 2023

vfdev-5 Jul 7, 2023

guptaaryan16 Jul 8, 2023

vfdev-5 Jul 10, 2023

vfdev-5 Jul 7, 2023

guptaaryan16 Jul 8, 2023

vfdev-5 Jul 10, 2023

vfdev-5 Jul 7, 2023

guptaaryan16 Jul 8, 2023

vfdev-5 Jul 10, 2023

vfdev-5 Jul 10, 2023

vfdev-5 commented Jul 10, 2023

guptaaryan16 commented Jul 10, 2023

vfdev-5 commented Jul 10, 2023 •

edited

Loading

vfdev-5 left a comment •

edited

Loading

		<i class="material-symbols-outlined icon">terminal</i>
		<span id="code">Code</span>

Wget option Added along with a new dropdown menu #265

Wget option Added along with a new dropdown menu #265

Conversation

guptaaryan16 commented Jun 26, 2023 • edited Loading

Description

Additional context

What is the purpose of this pull request?

netlify bot commented Jun 26, 2023 • edited Loading

✅ Deploy Preview for code-generator ready!

vfdev-5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vfdev-5 commented Jul 10, 2023

guptaaryan16 commented Jul 10, 2023

vfdev-5 commented Jul 10, 2023 • edited Loading

vfdev-5 left a comment • edited Loading

Choose a reason for hiding this comment

guptaaryan16 commented Jun 26, 2023 •

edited

Loading

netlify bot commented Jun 26, 2023 •

edited

Loading

vfdev-5 commented Jul 10, 2023 •

edited

Loading

vfdev-5 left a comment •

edited

Loading