Fix pt2_wrapper registration for unified TBE interface #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D64201777 |
❌ Deploy Preview for pytorch-fbgemm-docs failed.
|
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Oct 10, 2024
Summary: `*_pt2_wrapper` registration is currently in gpu source files so the wrappers are not found in CPU builds. To fix this, add codegen `m.def` in cpu source files for ops that have cpu support. Keep the `m.def` in gpu source files for GPU-only support (i.e., `ssd` and global weight decay `gwd` kernels. Differential Revision: D64201777
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Oct 11, 2024
Summary: X-link: facebookresearch/FBGEMM#339 `*_pt2_wrapper` registration is currently in gpu source files so the wrappers are not found in CPU builds. To fix this, add codegen `m.def` in cpu source files for ops that have cpu support. Keep the `m.def` in gpu source files for GPU-only support (i.e., `ssd` and global weight decay `gwd` kernels. Reviewed By: q10 Differential Revision: D64201777
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Oct 11, 2024
Summary: X-link: facebookresearch/FBGEMM#339 `*_pt2_wrapper` registration is currently in gpu source files so the wrappers are not found in CPU builds. To fix this, add codegen `m.def` in cpu source files for ops that have cpu support. Keep the `m.def` in gpu source files for GPU-only support (i.e., `ssd` and global weight decay `gwd` kernels. Reviewed By: q10 Differential Revision: D64201777
spcyppt
force-pushed
the
export-D64201777
branch
from
d73d070
to
98f5b04
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64201777 |
Summary: X-link: facebookresearch/FBGEMM#339 `*_pt2_wrapper` registration is currently in gpu source files so the wrappers are not found in CPU builds. To fix this, add codegen `m.def` in cpu source files for ops that have cpu support. Keep the `m.def` in gpu source files for GPU-only support (i.e., `ssd` and global weight decay `gwd` kernels. Reviewed By: q10 Differential Revision: D64201777
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Oct 11, 2024
Summary: X-link: facebookresearch/FBGEMM#339 `*_pt2_wrapper` registration is currently in gpu source files so the wrappers are not found in CPU builds. To fix this, add codegen `m.def` in cpu source files for ops that have cpu support. Keep the `m.def` in gpu source files for GPU-only support (i.e., `ssd` and global weight decay `gwd` kernels. Reviewed By: q10 Differential Revision: D64201777
spcyppt
force-pushed
the
export-D64201777
branch
from
98f5b04
to
e42c9bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64201777 |
|
This pull request has been merged in f59d5ee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
*_pt2_wrapperregistration is currently in gpu source files so the wrappers are not found in CPU builds.To fix this, add codegen
m.defin cpu source files for ops that have cpu support. Keep them.defin gpu source files for GPU-only support (i.e.,ssdand global weight decaygwdkernels.Differential Revision: D64201777