Temporary Fix: Skip TestAffineQuantizedTensorParallel on H100 #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1001
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9dec2af with merge base 09b8b3c ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
approved these changes
Oct 3, 2024
msaroufim
reviewed
Oct 3, 2024
| if not is_H100: | ||
| run_tests() | ||
| else: | ||
| print("Skipping TestAffineQuantizedTensorParallel: not supported on H100") |
There was a problem hiding this comment.
I'd prefer we explicitly put a skip test on the skipped test, this will also mess up the pytest output
msaroufim
reviewed
Oct 3, 2024
| @@ -1,12 +1,17 @@ | |||
| from torchao.testing.utils import copy_tests, TorchAOTensorParallelTestCase | |||
| from torch.testing._internal.common_utils import run_tests | |||
| from torchao.quantization import int8_weight_only | |||
| import torch | |||
There was a problem hiding this comment.
do you still see the error if you move the import torch statement above any ao imports?
There was a problem hiding this comment.
Moving torch as the first import does resolve some issues, but there are still issues of compatibility with H100. I'm working on another PR to add support for H100 (specially float8). #1003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current aqt test runs on bfloat16, float16 and float32, but the test doesn't run on H100 for these dtypes. As a temporray fix, skipping the test if H100
Created issue to track this: #1000