Move common ET/Aten op stuff to ops/library.h #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1116
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ee89aee with merge base 677af6f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63983380 |
kirklandsign
approved these changes
Oct 18, 2024
cccclai
approved these changes
Oct 18, 2024
Summary: Common aten/ET op registration code is in the linear op, but it is also needed by the embedding ops. This diff moves it to ops/library.h so that it can be used by the embedding op in a later diff. Reviewed By: digantdesai, kirklandsign Differential Revision: D63983380
metascroy
force-pushed
the
export-D63983380
branch
from
2fb157b
to
ee89aee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63983380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Common aten/ET op registration code is in the linear op, but it is also needed by the embedding ops. This diff moves it to ops/library.h so that it can be used by the embedding op in a later diff.
Reviewed By: digantdesai
Differential Revision: D63983380