Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bisector] checkout submodule one more time #1808

Closed
wants to merge 1 commit into from
Closed

Conversation

@xuzhao9 xuzhao9 changed the title Checkout submodule one more time [bisector] checkout submodule one more time Aug 3, 2023
@xuzhao9 xuzhao9 requested a review from janeyx99 August 4, 2023 13:15
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but potentially redundant. Was there an error that was run into when this was not the case?

@xuzhao9
Copy link
Contributor Author

xuzhao9 commented Aug 4, 2023

Seems fine, but potentially redundant. Was there an error that was run into when this was not the case?

@janeyx99
The error workflow is at https://github.com/pytorch/benchmark/actions/runs/5746035057/job/15576203551. It only appears for some of the bisection jobs. Not really sure why the command git checkout --recurse-submodules doesn't work in this case.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in dfe152c.

@xuzhao9 xuzhao9 deleted the xz9/fix-bisection branch August 4, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants