-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FBGEMM submodule #2293
Closed
Closed
Add FBGEMM submodule #2293
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cfa3f7c
Add FBGEMM submodule
xuzhao9 89f5e40
Add fbgemm genai to the nightly docker
xuzhao9 1d2830a
Update the default version in cuda utils
xuzhao9 bacbff4
Install fbgemm
xuzhao9 aeaaa0d
Fix dockerfile issues
xuzhao9 7e6c79d
Another fix
xuzhao9 b156359
Limit build target to A100/H100
xuzhao9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
docker build . -f torchbench-nightly.dockerfile -t ghcr.io/pytorch/torchbench:latest | ||
TORCHBENCH_BRANCH=${TORCHBENCH_BRANCH:-main} | ||
|
||
docker build . -f torchbench-nightly.dockerfile -t ghcr.io/pytorch/torchbench:latest \ | ||
--build-arg TORCHBENCH_BRANCH=${TORCHBENCH_BRANCH} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import argparse | ||
import subprocess | ||
import sys | ||
import os | ||
from pathlib import Path | ||
|
||
REPO_PATH = Path(os.path.abspath(__file__)).parent.parent.parent | ||
FBGEMM_PATH = REPO_PATH.joinpath("submodules", "FBGEMM", "fbgemm_gpu") | ||
|
||
def install_fbgemm(): | ||
cmd = ["pip", "install", "-r", "requirements.txt"] | ||
subprocess.check_call(cmd, cwd=str(FBGEMM_PATH.resolve())) | ||
# Build target A100(8.0) or H100(9.0) | ||
cmd = [sys.executable, "setup.py", "bdist_wheel", "--package_variant=genai", "-DTORCH_CUDA_ARCH_LIST=8.0;9.0"] | ||
subprocess.check_call(cmd, cwd=str(FBGEMM_PATH.resolve())) | ||
|
||
def test_fbgemm(): | ||
cmd = [sys.executable, "-c", '"import fbgemm_gpu.experimental.gen_ai"'] | ||
subprocess.check_call(cmd) | ||
|
||
if __name__ == "__main__": | ||
parser = argparse.ArgumentParser() | ||
parser.add_argument("--fbgemm", action="store_true", help="Install FBGEMM GPU") | ||
args = parser.parse_args() | ||
if args.fbgemm: | ||
install_fbgemm() | ||
test_fbgemm() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jianyuh Is this the right way to build FBGEMM GenAI OSS on A100/H100?