Add logger logging for remote fx graph cache get + put #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masnesral
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
masnesral
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D64484025 |
masnesral
added a commit
to masnesral/pytorch
that referenced
this pull request
Oct 17, 2024
…#138164) Summary: X-link: pytorch/benchmark#2512 Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging. Test Plan: 1) Landed D64483593 and waited for logger actualization. 2) Ran test script on devserver: `buck2 run mode/opt scripts/slarsen/torch_compile_model:run` 3) Queried dynamo_compile/sandbox: ``` (pytorch-3.10_4) devvm2296:~/local/pytorch-3.10_4 $ scuba -e="select time,co_filename,remote_fx_graph_cache_get_time_s,remote_fx_graph_cache_put_time_s from \`dynamo_compile/sandbox\` where remote_fx_graph_cache_put_time_s is not null" +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ | time | co_filename | remote_fx_graph_cache_get_time_s | remote_fx_graph_cache_put_time_s | +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ | 1729136266 | null | 0.05652284622192383 | 0.9691152572631836 | | 1729136263 | /data/users/slarsen/fbsource/buck-out/v2/gen/fbcode/289bb46b326874c6/scripts/slarsen/torch_compile_model/__run__/run-inplace#link-tree/scripts/slarsen/torch_compile_model/run.py | 0.8298435211181641 | 0.18642282485961914 | +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ ``` Reviewed By: oulgen Differential Revision: D64484025
masnesral
added a commit
to masnesral/benchmark
that referenced
this pull request
Oct 17, 2024
Summary: X-link: pytorch/pytorch#138164 Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging. Reviewed By: oulgen Differential Revision: D64484025
masnesral
force-pushed
the
export-D64484025
branch
from
ed67e88
to
3a90458
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64484025 |
masnesral
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
masnesral
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
masnesral
added a commit
to masnesral/benchmark
that referenced
this pull request
Oct 17, 2024
Summary: X-link: pytorch/pytorch#138164 Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging. Reviewed By: ezyang, oulgen Differential Revision: D64484025
masnesral
force-pushed
the
export-D64484025
branch
from
3a90458
to
4d300ec
Compare
masnesral
added a commit
to masnesral/pytorch
that referenced
this pull request
Oct 17, 2024
…#138164) Summary: X-link: pytorch/benchmark#2512 Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging. Test Plan: 1) Landed D64483593 and waited for logger actualization. 2) Ran test script on devserver: `buck2 run mode/opt scripts/slarsen/torch_compile_model:run` 3) Queried dynamo_compile/sandbox: ``` (pytorch-3.10_4) devvm2296:~/local/pytorch-3.10_4 $ scuba -e="select time,co_filename,remote_fx_graph_cache_get_time_s,remote_fx_graph_cache_put_time_s from \`dynamo_compile/sandbox\` where remote_fx_graph_cache_put_time_s is not null" +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ | time | co_filename | remote_fx_graph_cache_get_time_s | remote_fx_graph_cache_put_time_s | +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ | 1729136266 | null | 0.05652284622192383 | 0.9691152572631836 | | 1729136263 | /data/users/slarsen/fbsource/buck-out/v2/gen/fbcode/289bb46b326874c6/scripts/slarsen/torch_compile_model/__run__/run-inplace#link-tree/scripts/slarsen/torch_compile_model/run.py | 0.8298435211181641 | 0.18642282485961914 | +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ ``` Reviewed By: ezyang, oulgen Differential Revision: D64484025
masnesral
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
This pull request was exported from Phabricator. Differential Revision: D64484025 |
masnesral
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request was exported from Phabricator. Differential Revision: D64484025 |
masnesral
force-pushed
the
export-D64484025
branch
from
4d300ec
to
6680c56
Compare
masnesral
added a commit
to masnesral/benchmark
that referenced
this pull request
Oct 18, 2024
Summary: Pull Request resolved: pytorch#2512 X-link: pytorch/pytorch#138164 Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging. Reviewed By: ezyang, oulgen Differential Revision: D64484025
masnesral
added a commit
to masnesral/pytorch
that referenced
this pull request
Oct 18, 2024
…#138164) Summary: X-link: pytorch/benchmark#2512 Pull Request resolved: pytorch#138164 Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging. Test Plan: 1) Landed D64483593 and waited for logger actualization. 2) Ran test script on devserver: `buck2 run mode/opt scripts/slarsen/torch_compile_model:run` 3) Queried dynamo_compile/sandbox: ``` (pytorch-3.10_4) devvm2296:~/local/pytorch-3.10_4 $ scuba -e="select time,co_filename,remote_fx_graph_cache_get_time_s,remote_fx_graph_cache_put_time_s from \`dynamo_compile/sandbox\` where remote_fx_graph_cache_put_time_s is not null" +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ | time | co_filename | remote_fx_graph_cache_get_time_s | remote_fx_graph_cache_put_time_s | +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ | 1729136266 | null | 0.05652284622192383 | 0.9691152572631836 | | 1729136263 | /data/users/slarsen/fbsource/buck-out/v2/gen/fbcode/289bb46b326874c6/scripts/slarsen/torch_compile_model/__run__/run-inplace#link-tree/scripts/slarsen/torch_compile_model/run.py | 0.8298435211181641 | 0.18642282485961914 | +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ ``` Reviewed By: ezyang, oulgen Differential Revision: D64484025
masnesral
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
masnesral
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
Summary: Pull Request resolved: pytorch#2512 X-link: pytorch/pytorch#138164 Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging. Reviewed By: ezyang, oulgen Differential Revision: D64484025
|
This pull request was exported from Phabricator. Differential Revision: D64484025 |
masnesral
force-pushed
the
export-D64484025
branch
from
6680c56
to
d3c220d
Compare
masnesral
added a commit
to masnesral/pytorch
that referenced
this pull request
Oct 18, 2024
…#138164) Summary: X-link: pytorch/benchmark#2512 Pull Request resolved: pytorch#138164 Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging. Test Plan: 1) Landed D64483593 and waited for logger actualization. 2) Ran test script on devserver: `buck2 run mode/opt scripts/slarsen/torch_compile_model:run` 3) Queried dynamo_compile/sandbox: ``` (pytorch-3.10_4) devvm2296:~/local/pytorch-3.10_4 $ scuba -e="select time,co_filename,remote_fx_graph_cache_get_time_s,remote_fx_graph_cache_put_time_s from \`dynamo_compile/sandbox\` where remote_fx_graph_cache_put_time_s is not null" +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ | time | co_filename | remote_fx_graph_cache_get_time_s | remote_fx_graph_cache_put_time_s | +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ | 1729136266 | null | 0.05652284622192383 | 0.9691152572631836 | | 1729136263 | /data/users/slarsen/fbsource/buck-out/v2/gen/fbcode/289bb46b326874c6/scripts/slarsen/torch_compile_model/__run__/run-inplace#link-tree/scripts/slarsen/torch_compile_model/run.py | 0.8298435211181641 | 0.18642282485961914 | +------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------------------------------+ ``` Reviewed By: ezyang, oulgen Differential Revision: D64484025
masnesral
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
masnesral
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/pytorch#138164
Capture the timing for the remote fx graph cache get and put operations and add them to the logger logging.
Reviewed By: oulgen
Differential Revision: D64484025