Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to prep for weights_only default flip #2514

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mikaylagawarecki
Copy link

@mikaylagawarecki mikaylagawarecki commented Oct 17, 2024

Some fixes for pytorch/pytorch#137602

@xuzhao9
Copy link
Contributor

xuzhao9 commented Oct 18, 2024

cc @kit1980, can you help review this?

@@ -29,7 +31,13 @@ def __init__(self, test, device, batch_size=None, extra_args=[]):
)

self.model = models.resnet18(num_classes=10)
prev_wo_envvar = os.environ.get("TORCH_FORCE_NO_WEIGHTS_ONLY_LOAD", None)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have access to the torch.load call within opacus here, updating opacus also won't help because torchbench doesn't depend on a nightly of opacus but rather stable release

@facebook-github-bot
Copy link
Contributor

@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants