-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robustify prune_inferior_points tests against sorting order #2548
Conversation
9295acc
to
8cfaee7
Compare
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was exported from Phabricator. Differential Revision: D63260870 |
…2548) Summary: Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936 This change robustifies the tests against the point order (and also fixes a torch deprecation warning) Pull Request resolved: pytorch#2548 Differential Revision: D63260870 Pulled By: Balandat
7312cf6
to
22d0a29
Compare
This pull request was exported from Phabricator. Differential Revision: D63260870 |
…2548) Summary: Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936 This change robustifies the tests against the point order (and also fixes a torch deprecation warning) Pull Request resolved: pytorch#2548 Differential Revision: D63260870 Pulled By: Balandat
22d0a29
to
5639e33
Compare
This pull request was exported from Phabricator. Differential Revision: D63260870 |
…2548) Summary: Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936 This change robustifies the tests against the point order (and also fixes a torch deprecation warning) Pull Request resolved: pytorch#2548 Reviewed By: sdaulton Differential Revision: D63260870 Pulled By: Balandat
5639e33
to
96476af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 17010 17056 +46
=======================================
+ Hits 17007 17053 +46
Misses 3 3 ☔ View full report in Codecov by Sentry. |
…2548) Summary: Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936 This change robustifies the tests against the point order (and also fixes a torch deprecation warning). NOTE: Even though pytorch/pytorch#127936 was unlanded, getting these changes is will help robustify the tests going forward. NOTE: As this makes `torch.sort` use `stable=True`, this will come at a slight performance hit. However, the tensor sizes typically involved in `prune_inferior_points` are quite small (order of a few hundred items maybe), so this should be negligible. Pull Request resolved: pytorch#2548 Test Plan: unit tests Reviewed By: sdaulton, saitcakmak Differential Revision: D63260870 Pulled By: Balandat
This pull request was exported from Phabricator. Differential Revision: D63260870 |
96476af
to
f1ffb7e
Compare
Our nightly CI started failing, likely due to a sorting order change introduced in pytorch/pytorch#127936
This change robustifies the tests against the point order (and also fixes a torch deprecation warning)