-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARM][CUDA][OpenBLAS] Build with NOFORTRAN=1 FLAG #1861
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
common/install_openblas.sh
Outdated
@@ -7,6 +7,7 @@ git clone https://github.com/OpenMathLib/OpenBLAS.git -b v0.3.25 --depth 1 --sha | |||
|
|||
|
|||
OPENBLAS_BUILD_FLAGS=" | |||
NOFORTRAN=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is called also from manywheel/Dockerfile_aarch64 should we instead set this flag in Dockerfile aarch64 cuda ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinglvv Please make this script do if else, according to whether Dockerfile called this file with an argument or not. If yes, then it is arm cuda dockerfile calling. Otherwise, it is arm cpu dockerfile calling. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andrey for noticing this. Updated accordingly to build only for cu124 (currently cuda-aarch64 only). Will need to refactor this in the future.
common/install_openblas.sh
Outdated
@@ -14,6 +14,11 @@ DYNAMIC_ARCH=1 | |||
TARGET=ARMV8 | |||
CFLAGS=-O3 | |||
" | |||
if [ "$DESIRED_CUDA" = "cu124" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to use BASE_CUDA_VERSION 12.4 here instead
Looks like DESIRED_CUDA is not set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking, indeed it was not set. Let me use GPU_ARCH_TYPE: cuda-aarch64 instead
hi @tinglvv yes this looks good. I do see it here on gpu aarch64 builds: And not here: |
To fix the below error, need to run
apt install libopenblas-dev
Test build OpenBLAS without gfortran
cc @Aidyn-A @nWEIdia @ptrblck