Migrate to GitHub Actions #1181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osalpekar
reviewed
Sep 11, 2023
|
@vivekmig Can we merge this change, and fix the remaining broken job as a follow-up? We'd like to deprecate the old CircleCI jobs ASAP |
osalpekar
force-pushed
the
github_actions_test
branch
from
939d818
to
0131546
Compare
vivekmig
force-pushed
the
github_actions_test
branch
from
0131546
to
939d818
Compare
osalpekar
reviewed
Oct 9, 2023
.github/workflows/deploy.yml
Outdated
| repository: pytorch/captum | ||
| script: | | ||
| sudo chmod -R 777 . | ||
| ./scripts/install_via_pip.sh -n -d |
There was a problem hiding this comment.
For any calls to pip install within this script or any other script called from these workflows, we probably should add the following option to make the logs more readable: --progress-bar off
.github/workflows/deploy.yml
Outdated
| sudo chmod -R 777 . | ||
| ./scripts/install_via_pip.sh -n -d | ||
|
|
||
| if [[ $CIRCLE_PROJECT_USERNAME == "pytorch" && -z $CI_PULL_REQUEST && -z $CIRCLE_PR_USERNAME ]]; then |
There was a problem hiding this comment.
CIRCLE_PROJECT_USERNAME does not have a set value. Any env vars without a set value with fail with unbound environment variable since we runs this shell script with set -u.
vivekmig
force-pushed
the
github_actions_test
branch
from
d80ea70
to
627e13b
Compare
|
@vivekmig has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates test jobs from CircleCI to Github Actions