Split the get_random_model_and_data() method [1/n] #1252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 21, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
force-pushed
the
export-D55165054
branch
from
0268120
to
20fada4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
force-pushed
the
export-D55165054
branch
from
20fada4
to
bac9fdc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
force-pushed
the
export-D55165054
branch
from
bac9fdc
to
cc5d8b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
force-pushed
the
export-D55165054
branch
from
cc5d8b5
to
a94fc0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
force-pushed
the
export-D55165054
branch
from
a94fc0f
to
b1170a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
force-pushed
the
export-D55165054
branch
from
b1170a0
to
8c36dbe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
force-pushed
the
export-D55165054
branch
from
8c36dbe
to
b15b54a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
force-pushed
the
export-D55165054
branch
from
b15b54a
to
6934b9c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55165054 |
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 22, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
cicichen01
added a commit
to cicichen01/captum
that referenced
this pull request
Mar 23, 2024
Summary: As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts. This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str. Differential Revision: D55165054
|
This pull request has been merged in 8d793d5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. The get_random_model_and_data() method is used to construct testing data for influence and it is reported as too complex by flake8 (https://www.flake8rules.com/rules/C901.html). This series of diff will split the method and abstract the common parts.
This diff isolate the model part for different gpu usage settings. It also eliminate the mix usage of bool and str.
Differential Revision: D55165054