Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XNNPACK docs to use to_edge_transform_and_lower API #5344

Closed
wants to merge 1 commit into from
Closed

Update XNNPACK docs to use to_edge_transform_and_lower API #5344

wants to merge 1 commit into from

Conversation

GregoryComer
Copy link
Member

Quick doc update to use the new to_edge_transform_and_lower API, since we recommend this path now.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5344

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8769f25 with merge base ca2ac54 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer GregoryComer force-pushed the update-xnnpack-docs-use-new-lower-api branch 2 times, most recently from dd865a6 to 7e8b860 Compare September 13, 2024 10:42
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer GregoryComer force-pushed the update-xnnpack-docs-use-new-lower-api branch 2 times, most recently from 307bf93 to 9f87bdd Compare September 14, 2024 05:12
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer GregoryComer force-pushed the update-xnnpack-docs-use-new-lower-api branch from 9f87bdd to 8769f25 Compare September 14, 2024 09:47
@GregoryComer GregoryComer marked this pull request as ready for review September 15, 2024 00:13
mcr229
mcr229 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@mcr229 mcr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @GregoryComer

@mcr229
Copy link
Contributor

mcr229 commented Sep 16, 2024

do you mind also updating the examples/xnnpack/ folder to use this path as well?

https://github.com/pytorch/executorch/blob/main/examples/xnnpack/aot_compiler.py

@facebook-github-bot
Copy link
Contributor

@GregoryComer merged this pull request in 4357230.

@GregoryComer
Copy link
Member Author

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 15, 2024
@GregoryComer @pytorchbot
Update XNNPACK docs to use to_edge_transform_and_lower API (#5344)
e20b4e2 
Summary:
Quick doc update to use the new to_edge_transform_and_lower API, since we recommend this path now.

Pull Request resolved: #5344

Test Plan: Rendered doc for this PR: https://docs-preview.pytorch.org/pytorch/executorch/5344/tutorial-xnnpack-delegate-lowering.html.

Reviewed By: mcr229

Differential Revision: D62634494

Pulled By: GregoryComer

fbshipit-source-id: c28881a8be5b6398da6d506819c28d085ff2762e
(cherry picked from commit 4357230)
@pytorchbot
Copy link
Collaborator

Cherry picking #5344

The cherry pick PR is at #6244 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 15, 2024
Open
dvorjackz pushed a commit that referenced this pull request Oct 17, 2024
@pytorchbot @GregoryComer
Update XNNPACK docs to use to_edge_transform_and_lower API (#6244)
f7ce18e 
Update XNNPACK docs to use to_edge_transform_and_lower API (#5344)

Summary:
Quick doc update to use the new to_edge_transform_and_lower API, since we recommend this path now.

Pull Request resolved: #5344

Test Plan: Rendered doc for this PR: https://docs-preview.pytorch.org/pytorch/executorch/5344/tutorial-xnnpack-delegate-lowering.html.

Reviewed By: mcr229

Differential Revision: D62634494

Pulled By: GregoryComer

fbshipit-source-id: c28881a8be5b6398da6d506819c28d085ff2762e
(cherry picked from commit 4357230)

Co-authored-by: Gregory James Comer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcr229 mcr229 mcr229 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregoryComer @facebook-github-bot @mcr229 @pytorchbot