Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra checks for the provided dim order and strides. #5377

Closed
wants to merge 1 commit into from
Closed

Add extra checks for the provided dim order and strides. #5377

wants to merge 1 commit into from

Conversation

shoumikhin
Copy link
Contributor

Summary: Also make sure the scalar tensors stay static.

Differential Revision: D62681004

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5377

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 422e96a with merge base ef31608 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@shoumikhin shoumikhin force-pushed the export-D62681004 branch 2 times, most recently from cd90637 to 2456f70 Compare September 15, 2024 18:16
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@shoumikhin @facebook-github-bot
Add extra checks for the provided dim order and strides. (#5377)
422e96a 
Summary:
Pull Request resolved: #5377

Also make sure the scalar tensors stay static.

Differential Revision: D62681004
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62681004

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0a501eb.

@shoumikhin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Sep 16, 2024
@shoumikhin @pytorchbot
Add extra checks for the provided dim order and strides. (#5377)
0cd16d2 
Summary:
Pull Request resolved: #5377

Also make sure the scalar tensors stay static.

Reviewed By: kirklandsign

Differential Revision: D62681004

fbshipit-source-id: 57e035bcc5d9a4ffb2571144d7b3ed72ff84b193
(cherry picked from commit 0a501eb)
@pytorchbot
Copy link
Collaborator

Cherry picking #5377

The cherry pick PR is at #5390 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Sep 16, 2024
Open
dvorjackz pushed a commit that referenced this pull request Sep 17, 2024
@pytorchbot @shoumikhin
Add extra checks for the provided dim order and strides. (#5390)
6d3128f 
Add extra checks for the provided dim order and strides. (#5377)

Summary:
Pull Request resolved: #5377

Also make sure the scalar tensors stay static.

Reviewed By: kirklandsign

Differential Revision: D62681004

fbshipit-source-id: 57e035bcc5d9a4ffb2571144d7b3ed72ff84b193
(cherry picked from commit 0a501eb)

Co-authored-by: Anthony Shoumikhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoumikhin @facebook-github-bot @pytorchbot @kirklandsign