Add convenience load methond for forward. #5446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: People write `module->load_method("forward")` too often, let's simplify that a bit.
Reviewed By: kirklandsign
Differential Revision: D62906055
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5446
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit 1575d20 with merge base 2e1043b ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62906055 |
|
This pull request has been merged in b14dea8. |
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
Cherry picking #5446The cherry pick PR is at #5454 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
dvorjackz
pushed a commit
that referenced
this pull request
Sep 18, 2024
Add convenience load methond for forward. (#5446) Summary: Pull Request resolved: #5446 People write `module->load_method("forward")` too often, let's simplify that a bit. Reviewed By: kirklandsign Differential Revision: D62906055 fbshipit-source-id: d45934a27c61fd0ea644e6b58a21116dbc02fa17 (cherry picked from commit b14dea8) Co-authored-by: Anthony Shoumikhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: People write
module->load_method("forward")too often, let's simplify that a bit.Reviewed By: kirklandsign
Differential Revision: D62906055