-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and fix docs (namespaces, consistency) #6084
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6084
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 42a4d55 with merge base 61c501c (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D64152344 |
89d2a5e
to
4fca28f
Compare
This pull request was exported from Phabricator. Differential Revision: D64152344 |
Summary: Audit all instances of `\bexec_aten::` and `\btorch::` under `docs/`, updating where appropriate. The only remaining `torch::` instances are for kernels, which I didn't get a chance to migrate before v0.4.0. Also update the LLM Manual code to be consistent between the doc and main.cpp. Differential Revision: D64152344
4fca28f
to
560872c
Compare
This pull request was exported from Phabricator. Differential Revision: D64152344 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains a lots of changes unrelated to the title. If they must be landed together, please update the description
@malfet I mention it in the summary as "Also update the LLM Manual code to be consistent between the doc and main.cpp." Basically I had to update the namespaces in both main.cpp and in the doc that includes snippets of main.cpp, but noticed that they're different. I reformatted them and made them consistent as part of this. |
560872c
to
0bcf75f
Compare
Summary: Audit all instances of `\bexec_aten::` and `\btorch::` under `docs/`, updating where appropriate. The only remaining `torch::` instances are for kernels, which I didn't get a chance to migrate before v0.4.0. Also update the LLM Manual code to be consistent between the doc and main.cpp. Reviewed By: mergennachin Differential Revision: D64152344
This pull request was exported from Phabricator. Differential Revision: D64152344 |
0bcf75f
to
1e7be61
Compare
Summary: Audit all instances of `\bexec_aten::` and `\btorch::` under `docs/`, updating where appropriate. The only remaining `torch::` instances are for kernels, which I didn't get a chance to migrate before v0.4.0. Also update the LLM Manual code to be consistent between the doc and main.cpp. Reviewed By: mergennachin Differential Revision: D64152344
This pull request was exported from Phabricator. Differential Revision: D64152344 |
Summary: Audit all instances of `\bexec_aten::` and `\btorch::` under `docs/`, updating where appropriate. The only remaining `torch::` instances are for kernels, which I didn't get a chance to migrate before v0.4.0. Also: - Update the LLM Manual code to be consistent between the doc and main.cpp - Fix some LLM Manual issues: point to the latest release, and "main.cpp" instead of "main.h" Reviewed By: mergennachin Differential Revision: D64152344
1e7be61
to
97a5da0
Compare
This pull request was exported from Phabricator. Differential Revision: D64152344 |
Updated title/description because the scope of this creeped further |
Summary: Audit all instances of `\bexec_aten::` and `\btorch::` under `docs/`, updating where appropriate. The only remaining `torch::` instances are for kernels, which I didn't get a chance to migrate before v0.4.0. Also: - Update the LLM Manual code to be consistent between the doc and main.cpp - Fix some LLM Manual issues: point to the latest release, and "main.cpp" instead of "main.h" Reviewed By: mergennachin Differential Revision: D64152344
97a5da0
to
42a4d55
Compare
This pull request was exported from Phabricator. Differential Revision: D64152344 |
This pull request has been merged in 5512fe0. |
@pytorchbot cherry-pick --onto release/0.4 -c docs |
Summary: Pull Request resolved: #6084 Audit all instances of `\bexec_aten::` and `\btorch::` under `docs/`, updating where appropriate. The only remaining `torch::` instances are for kernels, which I didn't get a chance to migrate before v0.4.0. Also: - Update the LLM Manual code to be consistent between the doc and main.cpp - Fix some LLM Manual issues: point to the latest release, and "main.cpp" instead of "main.h" Reviewed By: mergennachin, Gasoonjia, Olivia-liu Differential Revision: D64152344 fbshipit-source-id: 2f6582429d5e3ef285b728350f937247996bb454 (cherry picked from commit 5512fe0)
Cherry picking #6084The cherry pick PR is at #6185 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Update and fix docs (namespaces, consistency) (#6084) Summary: Pull Request resolved: #6084 Audit all instances of `\bexec_aten::` and `\btorch::` under `docs/`, updating where appropriate. The only remaining `torch::` instances are for kernels, which I didn't get a chance to migrate before v0.4.0. Also: - Update the LLM Manual code to be consistent between the doc and main.cpp - Fix some LLM Manual issues: point to the latest release, and "main.cpp" instead of "main.h" Reviewed By: mergennachin, Gasoonjia, Olivia-liu Differential Revision: D64152344 fbshipit-source-id: 2f6582429d5e3ef285b728350f937247996bb454 (cherry picked from commit 5512fe0) Co-authored-by: Dave Bort <[email protected]>
Summary:
Audit all instances of
\bexec_aten::
and\btorch::
underdocs/
, updating where appropriate.The only remaining
torch::
instances are for kernels, which I didn't get a chance to migrate before v0.4.0.Also:
Differential Revision: D64152344