Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update landing page to include Llama (#6218) #6231

Closed
wants to merge 1 commit into from
Closed

Update landing page to include Llama (#6218) #6231

wants to merge 1 commit into from

Conversation

mergennachin
Copy link
Contributor

Summary:

We should promote llama page more and demote the LLM Manual.

allow-large-files

Differential Revision: D64375318

@mergennachin @facebook-github-bot
Update landing page to include Llama (pytorch#6218)
0302185 
Summary:

We should promote llama page more and demote the LLM Manual.

allow-large-files

Differential Revision: D64375318
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6231

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0302185 with merge base 7ba7990 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64375318

kirklandsign
kirklandsign reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@kirklandsign kirklandsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will use https://docs-preview.pytorch.org/pytorch/executorch/6231/llm/llama.html instead of https://docs-preview.pytorch.org/pytorch/executorch/6231/llm/getting-started.html?

@mergennachin
Copy link
Contributor Author

@kirklandsign both exist, just making sure llama2/readme.md is reachable from the website, currently it is not reachable at all.

the getting-started page is still there, but just demoted to fourth bullet in the TOC

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3e052a8.

@mergennachin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 16, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: expected one argument

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@mergennachin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 16, 2024
@mergennachin @pytorchbot
Update landing page to include Llama (#6231)
7fe58e9 
Summary:
Pull Request resolved: #6231

We should promote llama page more and demote the LLM Manual.

allow-large-files

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: dvorjackz

Differential Revision: D64375318

fbshipit-source-id: a6b07de4735691b5230e51ec7bc1957ce9a4463f
(cherry picked from commit 3e052a8)
@pytorchbot
Copy link
Collaborator

Cherry picking #6231

The cherry pick PR is at #6259 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 16, 2024
Open
mergennachin added a commit that referenced this pull request Oct 17, 2024
@pytorchbot @mergennachin
Update landing page to include Llama (#6218) (#6259)
8dd7774 
* Update landing page to include Llama (#6231)

Summary:
Pull Request resolved: #6231

We should promote llama page more and demote the LLM Manual.

allow-large-files

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: dvorjackz

Differential Revision: D64375318

fbshipit-source-id: a6b07de4735691b5230e51ec7bc1957ce9a4463f
(cherry picked from commit 3e052a8)

* Update index.rst

* Update getting-started.md

---------

Co-authored-by: Mergen Nachin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign left review comments

@dvorjackz dvorjackz dvorjackz approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mergennachin @facebook-github-bot @pytorchbot @dvorjackz @kirklandsign