Add pass for decomposing (log)softmax #6287
Open
+250
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Lundell <[email protected]> Change-Id: Ifda9b5a557ee29af5abc64569c51ec6bd6421c66
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6287
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit de30991 with merge base b1c94ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
facebook-github-bot
added
the
CLA Signed
digantdesai
approved these changes
Oct 16, 2024
| """ | ||
| if op in edge_softmax: | ||
| return ( | ||
| exir_ops.edge.aten.log.default, |
There was a problem hiding this comment.
nit can we use getattr and string concat?
There was a problem hiding this comment.
That's a neat suggestion, I'll keep it in mind when implementing a similar decomposition in the future
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ifda9b5a557ee29af5abc64569c51ec6bd6421c66