Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy issue with wandb.finish() #3283

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix mypy issue with wandb.finish() #3283

merged 1 commit into from
Sep 9, 2024

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 9, 2024

Fixes CI issue with mypy:

Run bash ./tests/run_code_style.sh mypy
+ '[' mypy = lint ']'
+ '[' mypy = fmt ']'
+ '[' mypy = mypy ']'
+ mypy --config-file mypy.ini
ignite/handlers/wandb_logger.py:144: error: Unused "type: ignore" comment 
[unused-ignore]
            self._wandb.finish()  # type: ignore[attr-defined]
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error in 1 file (checked 148 source files)

https://github.com/pytorch/ignite/actions/runs/10728076043/job/29751849022?pr=2901

@github-actions github-actions bot added the module: handlers Core Handlers module label Sep 9, 2024
@vfdev-5 vfdev-5 enabled auto-merge (squash) September 9, 2024 08:57
@vfdev-5 vfdev-5 merged commit e194891 into master Sep 9, 2024
21 of 23 checks passed
@vfdev-5 vfdev-5 deleted the fix-mypy-wandb-finish branch September 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vfdev-5