Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy < 2.0 pin to align with pytorch #1301

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

larryliu0820
Copy link
Contributor

Copy link

pytorch-bot bot commented Oct 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1301

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7312ae7 with merge base d1ab6e0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 15, 2024
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though PyTOrch don't fully test (especially in compile mode) numpy-2.X

@larryliu0820
Copy link
Contributor Author

I'll merge once all CI jobs are green

@larryliu0820 larryliu0820 merged commit dd9747f into main Oct 16, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torchchat is pinned to numpy < 2.0 but pytorch is pinned to numpy
3 participants