Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change et install directory to et-build from build, which now conflic… #227

Merged
merged 1 commit into from
Apr 17, 2024
Merged

change et install directory to et-build from build, which now conflic… #227

merged 1 commit into from
Apr 17, 2024

Conversation

metascroy
Copy link
Contributor

…ts with torchchat source code

@metascroy metascroy requested a review from guangy10 April 16, 2024 23:05
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 16, 2024
@mikekgfb mikekgfb self-requested a review April 17, 2024 00:06
mikekgfb
mikekgfb approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikekgfb mikekgfb merged commit 1befa1b into main Apr 17, 2024
8 of 15 checks passed
@malfet malfet deleted the change-build-dir branch April 30, 2024 16:51
malfet pushed a commit that referenced this pull request Jul 17, 2024
@metascroy @malfet
change et install directory to et-build from build, which now conflic…
227583f 
…ts with torchchat source code (#227)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@metascroy @malfet
change et install directory to et-build from build, which now conflic…
19fbb27 
…ts with torchchat source code (#227)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@metascroy @malfet
change et install directory to et-build from build, which now conflic…
3621cff 
…ts with torchchat source code (#227)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@metascroy @malfet
change et install directory to et-build from build, which now conflic…
cc59159 
…ts with torchchat source code (#227)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@metascroy @malfet
change et install directory to et-build from build, which now conflic…
483559e 
…ts with torchchat source code (#227)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@metascroy @malfet
change et install directory to et-build from build, which now conflic…
4cab1a5 
…ts with torchchat source code (#227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekgfb mikekgfb mikekgfb approved these changes

@guangy10 guangy10 Awaiting requested review from guangy10

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metascroy @mikekgfb @facebook-github-bot