Add quant workflow to validate.sh #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
guangy10
force-pushed
the
consolidate_ci_jobs
branch
2 times, most recently
from
e793a4a
to
7418f2a
Compare
mikekgfb
approved these changes
Apr 17, 2024
|
float16 w/ quant is generating garbage output on all platforms, for example, https://github.com/pytorch/torchchat/actions/runs/8716236562/job/23909449211?pr=229#step:7:2032 I will disable float16 for now. Wait, I don't see export.py and generate.py can take explicit |
guangy10
force-pushed
the
consolidate_ci_jobs
branch
from
7418f2a
to
16624eb
Compare
guangy10
force-pushed
the
consolidate_ci_jobs
branch
from
16624eb
to
e313e34
Compare
|
To ensure no new failures, trigger a periodic run on large models: https://github.com/pytorch/torchchat/actions/runs/8717420375 |
|
Segment fault with AOTI + quant int4 on linux x86_64 is an known issue iirc. |
|
The segfault with int4 groupwise quant in test-cpu-aoti x86_64 is an known issue, other than that no new failures. So I will ignore it and start merging. |
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge quant flow (w/ default dtype) to pull.yml/periodic.yml, for both cpu and cuda
Remove dup yml files, compile.yml, and compile_t4.yml