Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the linter on most of the repo #895

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Run the linter on most of the repo #895

merged 2 commits into from
Jul 11, 2024

Conversation

Jack-Khuu
Copy link
Contributor

We should make the lintrunner a part of the CI, but for now this PR does a naive application of easy lintrunner.

See #216 for a similar PR

pip install -r requirements-lintrunner.txt
lintrunner init
lintrunner -a --all-files

Note: The following are explicitly not linted in this PR

  • Distributed/
  • unsupported/
  • browser/
  • */third-party/*

Copy link

pytorch-bot bot commented Jul 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/895

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 48f35e9 with merge base a0962d1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 11, 2024
@Jack-Khuu Jack-Khuu merged commit 2540124 into main Jul 11, 2024
51 checks passed
@Jack-Khuu Jack-Khuu deleted the lint-711 branch July 11, 2024 16:56
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Initial linter run

* undoing changes to unsupported files
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Initial linter run

* undoing changes to unsupported files
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Initial linter run

* undoing changes to unsupported files
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Initial linter run

* undoing changes to unsupported files
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Initial linter run

* undoing changes to unsupported files
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Initial linter run

* undoing changes to unsupported files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants