-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run the linter on most of the repo #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/895
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 48f35e9 with merge base a0962d1 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Jul 11, 2024
Jack-Khuu
requested review from
malfet,
byjlw,
larryliu0820,
lucylq,
Gasoonjia and
vmpuri
July 11, 2024 15:18
byjlw
approved these changes
Jul 11, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Initial linter run * undoing changes to unsupported files
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Initial linter run * undoing changes to unsupported files
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Initial linter run * undoing changes to unsupported files
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Initial linter run * undoing changes to unsupported files
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Initial linter run * undoing changes to unsupported files
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Initial linter run * undoing changes to unsupported files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make the lintrunner a part of the CI, but for now this PR does a naive application of easy lintrunner.
See #216 for a similar PR
Note: The following are explicitly not linted in this PR