add optimizer key in EmbeddingFusedOptimizer and KeyValueEmbeddingFusedOptimizer. #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61668809 |
|
This pull request was exported from Phabricator. Differential Revision: D61668809 |
tristanhy
pushed a commit
to tristanhy/torchrec
that referenced
this pull request
Sep 30, 2024
…edOptimizer. (pytorch#2461) Summary: Pull Request resolved: pytorch#2461 Add field optimizer_key in Torchrec EmbeddingFusedOptimizer. During the initialization of embedding module BatchedFusedEmbeddingBag, pass the optimizer_key information from fused parameters when creating the EmbeddingFusedOptimizer. In sparse arch, update the optimizer key for TBE when creating a combined optimizer for different TBE modules. The optimizer_key in the combined fused optimizer can be extracted for learning rate warm up processing. Differential Revision: D61668809
tristanhy
force-pushed
the
export-D61668809
branch
from
860dd75
to
eabc204
Compare
…edOptimizer (pytorch#2461) Summary: Pull Request resolved: pytorch#2461 Add field optimizer_key in Torchrec EmbeddingFusedOptimizer. During the initialization of embedding module BatchedFusedEmbeddingBag, pass the optimizer_key information from fused parameters when creating the EmbeddingFusedOptimizer. In sparse arch, update the optimizer key for TBE when creating a combined optimizer for different TBE modules. The optimizer_key in the combined fused optimizer can be extracted for learning rate warm up processing. Reviewed By: really121 Differential Revision: D61668809
|
This pull request was exported from Phabricator. Differential Revision: D61668809 |
tristanhy
force-pushed
the
export-D61668809
branch
from
eabc204
to
634cb42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add field optimizer_key in Torchrec EmbeddingFusedOptimizer. During the initialization of embedding module BatchedFusedEmbeddingBag, pass the optimizer_key information from fused parameters when creating the EmbeddingFusedOptimizer.
In sparse arch, update the optimizer key for TBE when creating a combined optimizer for different TBE modules. The optimizer_key in the combined fused optimizer can be extracted for learning rate warm up processing.
Differential Revision: D61668809