Create an interface to enable eviction policy #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63879449 |
Summary: Pull Request resolved: pytorch#2478 To support per-feature TTL, feature split needs to be passed to the ZCH module so features that share the same embedding table can be differentiated. Differential Revision: D64163927
|
This pull request was exported from Phabricator. Differential Revision: D63879449 |
dracifer
force-pushed
the
export-D63879449
branch
from
c46c6fe
to
298f13e
Compare
dracifer
pushed a commit
to dracifer/torchrec
that referenced
this pull request
Oct 10, 2024
Summary: Pull Request resolved: pytorch#2479 To support various types of eviction policy, the `HashZchManagedCollisionModule` needs to be able to calculate a score (e.g., TTL) for each incoming ID and pass it to the kernel. The latter will make an informed eviction decision based on the existing score associated with the identity (stored in metadata), and a reference value (e.g., current timestamp). Refer to [Doc](https://docs.google.com/document/d/19s6N4-CWhveqhV1ePwrHAF8SIlzePsoxKElPRnnlo8c/edit?usp=sharing) for details. This Diff uses per-feature TTL as an example, and creates a scorer to assign a TTL for each ID with regard to the expiration hr of the feature. The score will be passed to the kernel (in a separate Diff) to perform eviction. Differential Revision: D63879449
Summary: Pull Request resolved: pytorch#2479 To support various types of eviction policy, the `HashZchManagedCollisionModule` needs to be able to calculate a score (e.g., TTL) for each incoming ID and pass it to the kernel. The latter will make an informed eviction decision based on the existing score associated with the identity (stored in metadata), and a reference value (e.g., current timestamp). Refer to [Doc](https://docs.google.com/document/d/19s6N4-CWhveqhV1ePwrHAF8SIlzePsoxKElPRnnlo8c/edit?usp=sharing) for details. This Diff uses per-feature TTL as an example, and creates a scorer to assign a TTL for each ID with regard to the expiration hr of the feature. The score will be passed to the kernel (in a separate Diff) to perform eviction. Differential Revision: D63879449
|
This pull request was exported from Phabricator. Differential Revision: D63879449 |
dracifer
force-pushed
the
export-D63879449
branch
from
298f13e
to
a897140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To support various types of eviction policy, the
HashZchManagedCollisionModuleneeds to be able to calculate a score (e.g., TTL) for each incoming ID and pass it to the kernel. The latter will make an informed eviction decision based on the existing score associated with the identity (stored in metadata), and a reference value (e.g., current timestamp). Refer to Doc for details.This Diff uses per-feature TTL as an example, and creates a scorer to assign a TTL for each ID with regard to the expiration hr of the feature. The score will be passed to the kernel (in a separate Diff) to perform eviction.
Differential Revision: D63879449