-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.12 to unittest CI jobs #8299
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8299
Note: Links to docs will display an error until the docs builds have been completed. ❌ 16 New Failures, 20 Unrelated FailuresAs of commit eca9531 with merge base 8afd547 (): NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Failing tests should be fixed by #8119, let's merge that one first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamp
Hey @NicolasHug! You merged this PR, but no labels were added. |
pytestmark = [pytest.mark.filterwarnings("error")] | ||
|
||
if sys.version_info[:2] >= (3, 12): | ||
# torchscript relies on some AST stuff that got deprecated in 3.12, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always sucks when new features come at odds with deprecations in other projects.
I was listening to the Pytorch Developer Podcast about Torchscript. I don't think we make too much explicit use of it today, but I'm excited to try it out!
Thanks for keeping things working so well!
Reviewed By: vmoens Differential Revision: D55062782 fbshipit-source-id: 57cf255fd0c82cad1bf7f40328cea78d6436b315
Towards #8293
cc @seemethere