Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.12 to unittest CI jobs #8299

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Mar 5, 2024

Towards #8293

cc @seemethere

Copy link

pytorch-bot bot commented Mar 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8299

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 20 Unrelated Failures

As of commit eca9531 with merge base 8afd547 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug
Copy link
Member Author

Failing tests should be fixed by #8119, let's merge that one first

@NicolasHug NicolasHug mentioned this pull request Mar 13, 2024
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@NicolasHug NicolasHug merged commit eb815ae into pytorch:main Mar 13, 2024
2 of 4 checks passed
@NicolasHug NicolasHug deleted the alefnalfenlafjenaef branch March 13, 2024 14:59
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug added module: ci other if you have no clue or if you will manually handle the PR in the release notes labels Mar 13, 2024
pytestmark = [pytest.mark.filterwarnings("error")]

if sys.version_info[:2] >= (3, 12):
# torchscript relies on some AST stuff that got deprecated in 3.12,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always sucks when new features come at odds with deprecations in other projects.

I was listening to the Pytorch Developer Podcast about Torchscript. I don't think we make too much explicit use of it today, but I'm excited to try it out!

Thanks for keeping things working so well!

facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2024
Reviewed By: vmoens

Differential Revision: D55062782

fbshipit-source-id: 57cf255fd0c82cad1bf7f40328cea78d6436b315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed module: ci other if you have no clue or if you will manually handle the PR in the release notes
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

4 participants