Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return labels for FER2013 if possible #8452

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 29, 2024

Closes #8118
Closes #8368
Closes #8415

If either the fer2013.csv file or icml_face_data.csv file is present, we use one of them instead of train.csv and test.csv, and return the labels for the test data instead of None. fer2013 has precedence over the rest, then icml_face_data.csv is used, and then train/test.csv are used.

Copy link

pytorch-bot bot commented May 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8452

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 4 Unrelated Failures

As of commit 6802e1c with merge base ab0b9a4 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug marked this pull request as draft May 29, 2024 14:38
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since the files cannot be downloaded by us, maybe add a sentence to the docstring on how to get test labels?

@@ -47,14 +52,25 @@ def __init__(
f"https://www.kaggle.com/c/challenges-in-representation-learning-facial-expression-recognition-challenge"
)

pixels_key = " pixels" if use_icml else "pixels" # yes, for real
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh FFS. Took me two minutes to notice the extra space. I share your feelings here, but maybe point out the space in the comment?

@NicolasHug NicolasHug marked this pull request as ready for review June 4, 2024 09:59
@NicolasHug NicolasHug merged commit 0325fdd into pytorch:main Jun 4, 2024
51 of 69 checks passed
@NicolasHug NicolasHug deleted the ferjneflajenfaf branch June 4, 2024 10:21
Copy link

github-actions bot commented Jun 4, 2024

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jun 7, 2024
Reviewed By: vmoens

Differential Revision: D58283847

fbshipit-source-id: 2d07b422bd8f0f308274ff81595f317a292fdc9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing labels in FER2013 test data
3 participants