Allow v2 Resize to resize longer edge exactly to max_size

[sidijju]

Addresses new feature request opened in #8358

Looking for feedback regarding v1 compatibility issues / potential workarounds for that.

cc @vfdev-5

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8459

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 7 Unrelated Failures

As of commit a9b8daf with merge base 1023987 ():

NEW FAILURES - The following jobs have failed:

• CMake / windows (windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-linux (3.12, linux.12xlarge, cpu) / linux-job (gh)
  RuntimeError: DGifOpenFileName() failed - 103
• Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh)
  RuntimeError: Command docker exec -t 844b5ea40a60a9cbbbfd8dfe96cb30c83c4bd517ceb219e899180b795d4bcb59 /exec failed with exit code 1
• Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
  RuntimeError: operator torchvision::nms does not exist
• Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Build M1 Conda / pytorch/vision / upload / conda-py3_8-cpu (gh) (trunk failure)
  Unable to find any artifacts for the associated workflow
• Build M1 Wheels / pytorch/vision / upload / wheel-py3_8-cpu (gh) (trunk failure)
  Unable to find any artifacts for the associated workflow
• CMake / macos (macos-m1-stable) / macos-job (gh) (trunk failure)
  RuntimeError: operator torchvision::nms does not exist
• Tests / unittests-macos (3.10, macos-m1-stable) / macos-job (gh) (trunk failure)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• Tests / unittests-macos (3.11, macos-m1-stable) / macos-job (gh) (trunk failure)
  RuntimeError: operator torchvision::nms does not exist
• Tests / unittests-macos (3.12, macos-m1-stable) / macos-job (gh) (trunk failure)
  RuntimeError: operator torchvision::nms does not exist
• Tests / unittests-macos (3.9, macos-m1-stable) / macos-job (gh) (trunk failure)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @sidijju!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[NicolasHug]

Thank you @sidijju ! Overall the PR looks great, I just pushed something to avoid overriding the _extract_params_for_v1_transform method. I also made a few comments below, LMK what you think.

The macos CI jobs are all red right now, but that's unrelated and can be safely ignored.

[sidijju]

Just pushed some changes @NicolasHug! Lmk if you have any thoughts

[NicolasHug]

Thanks a lot @sidijju , I pushed some minor changes but this LGTM. Thank you for the feature request and for the great PR!