Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adjust_hue on ARM #8618

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix adjust_hue on ARM #8618

merged 2 commits into from
Oct 14, 2024

Conversation

sclarkson
Copy link
Contributor

@sclarkson sclarkson commented Aug 30, 2024

Closes #8574

cc @vfdev-5

Copy link

pytorch-bot bot commented Aug 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8618

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 784bd76 with merge base ed55b03 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @sclarkson!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review @sclarkson . Thanks a lot for the report and for the fix.

@NicolasHug
Copy link
Member

@sclarkson we'll need you to sign the CLA before I can merge this PR. Thank you!

@sclarkson
Copy link
Contributor Author

@NicolasHug done

@NicolasHug NicolasHug changed the title Use two step conversion from float to uint8 to reduce platform dependence Fix adjust_hue on ARM Oct 14, 2024
@NicolasHug NicolasHug merged commit a7f0d25 into pytorch:main Oct 14, 2024
79 of 84 checks passed
@sclarkson sclarkson deleted the arm-adjust-hue-fix branch October 15, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adjust_hue broken on ARM64
3 participants