Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circular padding #8619

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

SeanScripts
Copy link

Not sure why this wasn't here already, it was already implemented in both pytorch and numpy, just under different names for the padding modes ("circular" and "wrap" respectively). I'm choosing "circular" here since this is for pytorch. Tested and it works fine.

Not sure why this wasn't here already, it was already implemented in both pytorch and numpy, just under different names for the padding modes ("circular" and "wrap" respectively). I'm choosing "circular" here since this is for pytorch. Tested and it works fine.
Copy link

pytorch-bot bot commented Aug 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8619

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @SeanScripts!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@NicolasHug
Copy link
Member

Thanks for the PR @SeanScripts . Have you found that useful in practice? Note that we aren't adding more features to the traditional torchvision.transforms namespace. New features and enhancements should be going into torchvision.transforms.v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants