Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix saving versions on windows #8792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bjarzemb
Copy link

@bjarzemb bjarzemb commented Dec 9, 2024

Before:

>python -c "import torchvision; print(torchvision.__version__)"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: module 'torchvision' has no attribute '__version__'

After:

>python -c "import torchvision; print(torchvision.__version__)"
0.20.0a0+6279faa

Copy link

pytorch-bot bot commented Dec 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8792

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 33ee3d7 with merge base a9a726a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @bjarzemb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

setup.py Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Hug <[email protected]>
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarzemb

@NicolasHug
Copy link
Member

@bjarzemb please make sure to sign the CLA so I can merge this PR :) !
code.facebook.com/cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants