PR for release 1.0.0 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update repo steffenlem to sradownloader
Template merge
Adding process for downloading metadata from SRA
SusiJo
approved these changes
Apr 23, 2021
SusiJo
reviewed
Apr 23, 2021
| @@ -5,21 +5,21 @@ | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
|
|
|||
| <meta name="description" content="steffenlem/sradownloader: A pipeline to download raw data from SRA"> | |||
| <title>steffenlem/sradownloader Pipeline Report</title> | |||
| <meta name="description" content="/sradownloader: A pipeline to download raw data from SRA"> | |||
There was a problem hiding this comment.
Should probably changed to content:"qbic-pipelines/sradownloader"
SusiJo
reviewed
Apr 23, 2021
| @@ -11,28 +11,38 @@ | |||
|
|
|||
| process { | |||
|
|
|||
| cpus = { check_max( 8 * task.attempt, 'cpus' ) } | |||
| cpus = { check_max( 1 * task.attempt, 'cpus' ) } | |||
| memory = { check_max( 7.GB * task.attempt, 'memory' ) } | |||
| time = { check_max( 4.h * task.attempt, 'time' ) } | |||
|
|
|||
| errorStrategy = { task.exitStatus in [143,137,104,134,139] ? 'retry' : 'finish' } | |||
| maxRetries = 1 | |||
There was a problem hiding this comment.
It might help to raise maxRetries if there are connection timeouts to the NCBI server
SusiJo
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Hi @ggabernet,
Thanks for the PR! Looks great! :) I've just added a few comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steffenlem/sradownloader pull request
Many thanks for contributing to steffenlem/sradownloader!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md