Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose 'bdecode limits' settings #19291

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Expose 'bdecode limits' settings #19291

merged 2 commits into from
Jul 11, 2023

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Jul 9, 2023

  • Expose 'max torrent file size' setting
  • Expose 'bdecode limits' settings
    This includes:
    • Bdecode depth limit
    • Bdecode token limit

@Chocobo1 Chocobo1 added WebUI WebUI-related issues/changes GUI GUI-related issues/changes WebAPI WebAPI-related issues/changes labels Jul 9, 2023
@Chocobo1 Chocobo1 added this to the 4.6.0 milestone Jul 9, 2023
glassez
glassez reviewed Jul 9, 2023
View reviewed changes
src/base/preferences.cpp Show resolved Hide resolved
src/base/bittorrent/sessionimpl.cpp Outdated Show resolved Hide resolved
@glassez
Copy link
Member

glassez commented Jul 9, 2023

@Chocobo1
Did you try to set some extreme values to these settings? I would expect that at least qBittorrent don't crash and allow you to fix them (if they are unusable).

@Chocobo1
Copy link
Member Author

Chocobo1 commented Jul 9, 2023

Did you try to set some extreme values to these settings? I would expect that at least qBittorrent don't crash and allow you to fix them (if they are unusable).

I did some rudimentary tests and qbt will display proper error dialogs instead of crashing.

@Chocobo1 Chocobo1 requested a review from a team July 9, 2023 07:24
@Chocobo1
Expose 'bdecode limits' settings
5a660fc 
This includes:
* Bdecode depth limit
* Bdecode token limit
@Chocobo1 Chocobo1 merged commit 4f6038c into qbittorrent:master Jul 11, 2023
17 checks passed
@Chocobo1 Chocobo1 deleted the limits branch July 11, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez approved these changes

@thalieht thalieht thalieht approved these changes

Assignees
No one assigned
Labels
GUI GUI-related issues/changes WebAPI WebAPI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Chocobo1 @glassez @thalieht