Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to stop seeding when torrent has been inactive #19294

Merged
merged 8 commits into from
Jul 15, 2023
Merged

Add option to stop seeding when torrent has been inactive #19294

merged 8 commits into from
Jul 15, 2023

Conversation

c4181
Copy link
Contributor

@c4181 c4181 commented Jul 9, 2023

This feature was requested in #533, #8073, and #15939. This feature currently exists in Transmission. I used Transmission for a bit and after coming back to qBitorrent I wanted the feature implemented as well.

  • Adds the ability to seed until a torrent has been inactive for a specified number of minutes
  • Changes UI labels for existing seed limit to read "total seeding time" instead of "seeding time"
  • Adds new UI options for "inactive seeding time"

App UI Changes

Options Dialog

image

Torrent Options Dialog

image

Web UI Changes

Preferences

image

Share Ratio

image

@glassez glassez added WebUI WebUI-related issues/changes GUI GUI-related issues/changes Core WebAPI WebAPI-related issues/changes labels Jul 10, 2023
@glassez
Copy link
Member

glassez commented Jul 10, 2023

@c4181
Seems you forgot to add the code in DBResumeDataStorage that update the layout of existing database to add new column.

Chocobo1
Chocobo1 reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@Chocobo1 Chocobo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some coding style suggestions.
Also note that out CI failed due to coding style in webui files, please take a look and fix them too. Thanks.

src/webui/api/appcontroller.cpp Outdated Show resolved Hide resolved
src/gui/optionsdialog.ui Outdated Show resolved Hide resolved
src/gui/optionsdialog.cpp Outdated Show resolved Hide resolved
src/base/bittorrent/sessionimpl.cpp Outdated Show resolved Hide resolved
src/base/bittorrent/torrentimpl.cpp Outdated Show resolved Hide resolved
@c4181
Copy link
Contributor Author

c4181 commented Jul 10, 2023

@glassez Added code to increment the version and add the column

@Chocobo1 I Applied all your suggestions and fixed the error from the CI

@glassez glassez requested a review from a team July 11, 2023 14:13
@glassez glassez requested a review from a team July 12, 2023 04:00
thalieht
thalieht previously approved these changes Jul 12, 2023
View reviewed changes
glassez
glassez previously approved these changes Jul 12, 2023
View reviewed changes
@glassez
Copy link
Member

glassez commented Jul 13, 2023

@c4181
Could you resolve merge conflicts?

@c4181 c4181 dismissed stale reviews from glassez and thalieht via 62ffbfe July 13, 2023 21:38
@c4181 c4181 force-pushed the stop-seeding-after-inactive branch from f7d3818 to 62ffbfe Compare July 13, 2023 21:38
@c4181
Copy link
Contributor Author

c4181 commented Jul 13, 2023

@c4181 Could you resolve merge conflicts?

Resolved

@c4181 c4181 requested review from glassez and thalieht July 13, 2023 23:17
glassez
glassez reviewed Jul 14, 2023
View reviewed changes
src/gui/optionsdialog.cpp Outdated Show resolved Hide resolved
Chocobo1
Chocobo1 reviewed Jul 14, 2023
View reviewed changes
src/gui/optionsdialog.cpp Outdated Show resolved Hide resolved
@glassez glassez merged commit 35e1849 into qbittorrent:master Jul 15, 2023
17 checks passed
@glassez
Copy link
Member

glassez commented Jul 15, 2023

@c4181
Thank you!

@glassez glassez mentioned this pull request Jul 15, 2023
Merged
@rmartin16 rmartin16 mentioned this pull request Jul 16, 2023
Merged
@c4181 c4181 deleted the stop-seeding-after-inactive branch July 24, 2023 16:42
@Peuuuur-Noel Peuuuur-Noel mentioned this pull request Oct 28, 2023
Closed
@thezoggy thezoggy mentioned this pull request Dec 23, 2023
Open
1 task
@glassez glassez mentioned this pull request Dec 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 left review comments

@glassez glassez glassez approved these changes

@thalieht thalieht Awaiting requested review from thalieht

Assignees
No one assigned
Labels
Core GUI GUI-related issues/changes WebAPI WebAPI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c4181 @glassez @thalieht @Chocobo1