Disable update checks on versions before Windows 10 #19295
Conversation
|
This is meant to go into the 4.5.5 release. The v4.5.5 will be the last of the series. It is the perfect time to disable the update mechanism for people running on incompatible Win versions for the next qbt release. |
sledgehammer999
force-pushed
the
noop-update
branch
from
b2b7341
to
1201cbc
Compare
src/gui/mainwindow.cpp
Outdated
| , tr("This is the last supported version for your Windows version.") | ||
| , QMessageBox::Ok, this}; | ||
| msgBox->setAttribute(Qt::WA_DeleteOnClose); | ||
| msgBox->setWindowModality(Qt::NonModal); |
There was a problem hiding this comment.
Why it is non-modal? In this case the user is available to produce multiple similar dialogs at a time.
There was a problem hiding this comment.
It's a copy-paste from here:
qBittorrent/src/gui/mainwindow.cpp
Line 1778 in c8763f0
There was a problem hiding this comment.
The non modal options was implemented with PR #16678.
On second read, that was due to the operation being asyncronous and the user might have opened other dialogs in the meantime.
I'll remove it.
On versions before Windows 10 the user is running the Qt5 build. The next qBittorrent release will change to Qt6 as the default build. It is counterintuitive to tell the user about available updates when they are running an incompatible Windows version.
sledgehammer999
force-pushed
the
noop-update
branch
from
1201cbc
to
93204a6
Compare
|
@sledgehammer999 |
OMG! |
|
Will it be bad if I merge this and don't wait for translators for the new string (and make a release)? |
IMO, this string doesn't play a big role in everyday use, so it shouldn't be a big problem to leave it untranslated. |
This release is supposed to be the last one in v4_5_x. |
|
@sledgehammer999 |
|
Should below not have been changed to qBittorrent/src/gui/programupdater.cpp Line 110 in 7d7097b |
On versions before Windows 10 the user is running the Qt5 build.
The next qBittorrent release will change to Qt6 as the default build.
It is counterintuitive to tell the user about available updates when they are running an incompatible Windows version.